fix(docker): add py3-setuptools for arm builds on node 20#4341
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019c4f56-720a-73f9-a47f-2074c121bfd1 Co-authored-by: Amp <amp@ampcode.com>
📝 WalkthroughWalkthroughThe Dockerfile was modified to include Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds the py3-setuptools package to the Docker build dependencies for ARM architectures (arm64 and arm/v7) when running on Node 20. This change aims to address potential build failures related to Python setuptools missing during the native module compilation process with node-gyp.
Changes:
- Added
py3-setuptoolsto the ARM platform-specific Alpine package installation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
No idea if this fixes it but trying anyways
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
Summary by CodeRabbit