feat: add option to Decline request with a Reason#4205
feat: add option to Decline request with a Reason#4205samohtxotom wants to merge 2 commits intosct:developfrom
Conversation
samohtxotom
requested review from
OwsleyJr,
TheCatLady,
danshilm and
sct
as code owners
samohtxotom
changed the title
samohtxotom
changed the title
|
Nice job! Hope to see that feature in jellyseerr as well. Thanks! |
|
@sct is there any chance to get that? i need it. And can the declined reason add to the E-Mail's? |
|
Cool looking PR! I think the decline reason button should probably be consolidated into the main decline button as a dropdown. Also not sure how I feel about the quick presets. Is there a limit to them and if not, what does it look like with a bunch? |
There was a problem hiding this comment.
Do we need this Entity? Can we not just add this directly to the MediaRequest entity
There was a problem hiding this comment.
We should probably add a limit to the decline reason and validation for that here/backend. Not sure if I'm seeing it here
| <div className="space-y-3"> | ||
| <div className="text-sm font-medium text-gray-200"> | ||
| {intl.formatMessage(messages.quickReasons)} | ||
| </div> |
There was a problem hiding this comment.
This probably shouldn't show if there are no presets.
|
should this not been moved to the new Seerr?? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This had traction and now seems like it's dead. It's a shame a lot of new features for this app seem to be getting ignored. |
5 participants
Adds Decline with Reasons feature, includes custom message and saveable presets
Description
Adds new button next to existing Decline button that opens Decline with Reasons, presets are displayed that if clicked on immedaitely submit the form, meaning only one extra button press to add a preset reason. Custom text box with option to save as a preset for future use. Displays decline reason in Declined badge (truncated with tooltip for long messages/small screens) and also intergrated into notifications.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
#4184 , #2270 , #593