Open
Conversation
TheForce172
approved these changes
Feb 27, 2026
Contributor
TheForce172
left a comment
TheForce172
left a comment
There was a problem hiding this comment.
Willing to approve this as long as one final check is done. What happens if a prop is selected while the ship editor is open?
Contributor
Author
Selecting a ship with the Props dialog open will grey out the Props dialog. Selecting a prop with the Ships dialog open will grey out the Ships dialog. |
Contributor
|
Perfect! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds full Props support to QtFRED with dialog editor and everything.
Much of the viewport and fredrender changes are just to get it moderately functioning. Both the viewport editor and fred render are going to get major refactors soon as they are broken in many ways.
Part of what's needed in #7229