-
Notifications
You must be signed in to change notification settings - Fork 7
[Snyk] Security upgrade django from 3.2.25 to 4.2.28 #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-15183335
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to upgrade Django from version 3.2.25 to 4.2.28 to address a SQL Injection vulnerability (SNYK-PYTHON-DJANGO-15183335). However, the PR is based on incorrect dependency information - the project already uses Django 5.2.3 as specified in requirements/base.txt, which is significantly newer than the target version 4.2.28.
Changes:
- Adds
django>=4.2.28to requirements/production.txt
| elastic-apm==6.21.4.post8347027212 | ||
| django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability No newline at end of file |
Copilot
AI
Feb 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change creates a conflicting Django version requirement. The base.txt file (which is included via -r base.txt on line 3) already specifies django==5.2.3. Adding django>=4.2.28 to production.txt will cause a dependency conflict since pip cannot satisfy both django==5.2.3 and django>=4.2.28 simultaneously (even though 5.2.3 is greater than 4.2.28, the exact version pin in base.txt takes precedence and conflicts).
The project is already using Django 5.2.3, which is significantly newer than 4.2.28 and should already include the security fixes that this PR aims to address. This PR appears to be based on outdated dependency information and is not needed.
| elastic-apm==6.21.4.post8347027212 | |
| django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability | |
| elastic-apm==6.21.4.post8347027212 |
| # ------------------------------------------------------------------------------ | ||
| elastic-apm==6.21.4.post8347027212 No newline at end of file | ||
| elastic-apm==6.21.4.post8347027212 | ||
| django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability No newline at end of file |
Copilot
AI
Feb 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states this upgrades Django from 3.2.25 to 4.2.28, but the codebase already has Django 5.2.3 specified in requirements/base.txt. This indicates that the Snyk scan may have been performed on outdated or incorrect dependency information. The project does not actually use Django 3.2.25, so this security upgrade is not applicable to the current state of the codebase.
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-15183335
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requirements/production.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection