fixing numpy row_stack deprecation#227
Merged
tshead2 merged 1 commit intosandialabs:mainfrom Mar 13, 2026
Merged
Conversation
Member
|
Looks like a winner @harmsm, many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Replace deprecated
numpy.row_stackwithnumpy.vstackDescription
This PR replaces occurrences of
numpy.row_stackwithnumpy.vstack. As of recent NumPy versions,row_stackis a deprecated alias forvstack. Usingrow_stacktriggersDeprecationWarning.Changes
The following files were updated to use
numpy.vstack:toyplot/coordinates.py: Updatedendpoints = numpy.row_stack(((x1, y1), (x2, y2)))to usevstack.toyplot/html.py: Updatedp = numpy.row_stack(((x1, y1), (x2, y2)))to usevstack.Testing
Verified that the
DeprecationWarningis resolved and that the code paths continue to function as expected. (There are a few failingbehavetests, but they were failing on my machine before the change too).