Fix security vulnerabilities: XSS, hyperlink validation, and Ghostscript hardening#222
Open
garland3 wants to merge 4 commits intosandialabs:mainfrom
Open
Fix security vulnerabilities: XSS, hyperlink validation, and Ghostscript hardening#222garland3 wants to merge 4 commits intosandialabs:mainfrom
garland3 wants to merge 4 commits intosandialabs:mainfrom
Conversation
- Escape </script> sequences in generated JavaScript to prevent injection. - Add unit test suite with test for script escaping. - Integrate unit tests into CI/CD workflow. Addresses security issue where user-controlled data could inject arbitrary script.
…s#219) - Only allow http, https, mailto, ftp, or relative URLs in require.hyperlink - Add unit tests for safe and unsafe schemes Addresses security issue where javascript: and data: URIs could be used for injection.
- Use shutil.which() and os.path.realpath() for absolute Ghostscript path - Ensure -dSAFER is included in both render() and render_frames() - Use consistent _gs_resolution in render_frames() - Add unit test for Ghostscript command setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple security issues:
Changes include: