Update Modal Box to Bootstrap 3 Syntax#16
Open
Mastergalen wants to merge 1 commit intosamwillis:masterfrom
Mastergalen:patch-1
Open
Update Modal Box to Bootstrap 3 Syntax#16Mastergalen wants to merge 1 commit intosamwillis:masterfrom Mastergalen:patch-1
Mastergalen wants to merge 1 commit intosamwillis:masterfrom
Mastergalen:patch-1
Conversation
|
+1 on this issue commit 60188c2 works for me, |
|
The changes on lines 1378-1392 are breaking changes (and unrelated to this issue). @samwillis should reject this request, even though the modal functionality is corrected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes modal not appearing when using Bootstrap 3. Does, however, break Bootstrap 2 compatibility.
Updates BS 2 modal syntax to BS 3 syntax.