[systemd] Fix dangling symlink in /etc#17
Open
nephros wants to merge 1 commit intosailfishos:masterfrom
Open
Conversation
Thaodan
requested changes
Oct 8, 2024
Contributor
Thaodan
left a comment
Thaodan
left a comment
There was a problem hiding this comment.
I don't think we need the symlink anymore.
Further: Please always edit systemd.spec and then run precheckin.sh to patch systemd-mini.spec.
Author
Hm, I guess the fact that this may have been broken ever since aarch64 was introduced supports this.
Done. So, shall I drop the whole symlink in this PR? |
Contributor
|
"Peter G." ***@***.***> writes:
> Further: Please always edit systemd.spec and then run precheckin.sh to patch systemd-mini.spec.
Done.
So, shall I drop the whole symlink in this PR?
Yes.
Also please use rebase when fixing your commits.
|
Likely not needed anymore. Also it was a dangling link pointing to /usr/lib64 on aarch64.
nephros
force-pushed
the
fix-macros-link
branch
from
a81f651 to
9416afc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... it would point to /usr/lib64 on aarch64