Conversation
spiiroin
approved these changes
Jul 7, 2025
Contributor
Author
|
Reworked the PR to split the backends into separate classes to make the code more readable. |
monich
reviewed
Mar 5, 2026
| const size_t maxEvents = 64; | ||
| } | ||
|
|
||
| #ifdef USE_BINDER |
Member
There was a problem hiding this comment.
do these implementation specific headers need to be part of the interface?
Contributor
Author
There was a problem hiding this comment.
There would be a lot more refactoring needed to get rid of these since HybrisAdaptor uses sensors_event_t which comes from these headers.
monich
reviewed
Mar 5, 2026
Don't wait for hwbinder servicemanager when checking if hidl backend is supported. One new devices hwbinder servicemanager is not present anymore and waiting for servicemanager would cause the service to wait forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.