Android: implement Window::safe_area#4506
Open
nicoburns wants to merge 1 commit intorust-windowing:masterfrom
Open
Android: implement Window::safe_area#4506nicoburns wants to merge 1 commit intorust-windowing:masterfrom
Window::safe_area#4506nicoburns wants to merge 1 commit intorust-windowing:masterfrom
Conversation
19e5226 to
11166d1
Compare
Window::safe_area for androidWindow::safe_area
Signed-off-by: Nico Burns <nico@nicoburns.com>
11166d1 to
bd06339
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
Window::safe_areafor Android. This replaces the platform-specificWindowExtAndroid::content_rectmethod.Android provides the
topandrightcoordinates as offsets from the top left (0, 0) point rather than as insets from the nearest side. So these are subtracted from the outer size to normalize them according the existing semantics ofWindow::safe_area.changelogmodule if knowledge of this change could be valuable to users