vhost-user: Add support for GET_SHMEM_CONFIG message#339
Open
aesteve-rh wants to merge 1 commit intorust-vmm:mainfrom
Open
vhost-user: Add support for GET_SHMEM_CONFIG message#339aesteve-rh wants to merge 1 commit intorust-vmm:mainfrom
aesteve-rh wants to merge 1 commit intorust-vmm:mainfrom
Conversation
aesteve-rh
requested review from
Ablu,
epilys,
eryugey,
germag,
jiangliu,
sboeuf,
slp and
stefano-garzarella
as code owners
Contributor
Author
aesteve-rh
force-pushed
the
mmap-backend-cmd
branch
from
c1382e5 to
f93cc74
Compare
fkm3
reviewed
Dec 17, 2025
aesteve-rh
force-pushed
the
mmap-backend-cmd
branch
from
f93cc74 to
89c6bea
Compare
Contributor
|
Shouldn't there be a |
aesteve-rh
force-pushed
the
mmap-backend-cmd
branch
from
89c6bea to
d91538a
Compare
Contributor
Author
True, good catch! Added. |
alyssais
suggested changes
Jan 7, 2026
Member
|
CI issues should be unrelated and fixed by #340 |
aesteve-rh
force-pushed
the
mmap-backend-cmd
branch
2 times, most recently
from
6ab007f to
6b49347
Compare
aesteve-rh
force-pushed
the
mmap-backend-cmd
branch
2 times, most recently
from
38a0579 to
bfef1da
Compare
alyssais
approved these changes
Jan 19, 2026
Contributor
alyssais
left a comment
alyssais
left a comment
There was a problem hiding this comment.
Thanks and sorry for the confusion!
crosvm-bot
pushed a commit
to google/crosvm
that referenced
this pull request
Jan 23, 2026
This is not intended to be variable size in the spec. Making it fixed-size makes the implementation much simpler, and avoids sending variable-size responses to frontends that may not understand them. TEST=Run crosvm and another frontend with a crosvm vhost-user GPU device. Link: rust-vmm/vhost#339 (comment) Change-Id: I33adad1b3d314f9fc276d1b63b9f79102d919880 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/7486921 Reviewed-by: Frederick Mayle <fmayle@google.com> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org> Reviewed-by: Sergio Rodriguez <sorama@google.com>
stefano-garzarella
requested changes
Feb 3, 2026
Add support for GET_SHMEM_CONFIG message to retrieve VirtIO Shared Memory Regions configuration. This is useful when the frontend is unaware of specific backend type and configuration of the memory layout. Based on the patch [1] which is just waiting for being merged. [1] - https://lore.kernel.org/all/20251111091058.879669-1-aesteve@redhat.com/ Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
mmap-backend-cmd
branch
from
bfef1da to
a1f0337
Compare
stefano-garzarella
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for GET_SHMEM_CONFIG message to retrieve VirtIO Shared Memory Regions configuration.
This is useful when the frontend is unaware of specific backend type and configuration of the memory layout.
Based on the patch [1] which is just waiting for being merged.
[1] -
https://lore.kernel.org/all/20251111091058.879669-1-aesteve@redhat.com/
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.