Added function get_enabled to export vring enable status.#291
Added function get_enabled to export vring enable status.#291WeiChungHsu wants to merge 1 commit intorust-vmm:mainfrom
Conversation
The vring is disabled and RX/TX queue is set to not-ready during snapshot. But vhost-device process keeps access vring and queue after snapshot which caused system hang. We need to export vring enabled and disabled status for snapshot feature so that the vhost-device would skip vring/queue access aftr snapshot to avoid hang. Signed-off-by: Wei-Chung Hsu <weihsu@google.com>
|
@WeiChungHsu why closing #284 in favor of this? What are the differences? Please in the future avoid that, it's better to continue on the same PR to check the history of reviews, etc. |
Sorry, I tried many git commands, but can't rebase this PR on current main. In addition, I accidentally close the old PR. Sorry about that. |
No need to apologize, it can happen, it was to understand the reason, next time explain it even if it is a mistake. |
|
There are questions still open like: #284 (comment)
|
| fn set_enabled(&self, enabled: bool); | ||
|
|
||
| /// Get vring enabled state. | ||
| fn get_enabled(&self) -> bool; |
There was a problem hiding this comment.
This should be named is_enabled.
Summary of the PR
The vring is disabled and RX/TX queue is set to
not-ready during snapshot. But vhost-device process
keeps access vring and queue after snapshot which
caused system hang. We need to export vring enabled
and disabled status for snapshot feature so that
the vhost-device would skip vring/queue access
after snapshot to avoid hang.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.