Skip to content

Comments

Add support for organization-wide default configuration#2292

Merged
Urgau merged 1 commit intorust-lang:masterfrom
Urgau:org-config
Feb 19, 2026
Merged

Add support for organization-wide default configuration#2292
Urgau merged 1 commit intorust-lang:masterfrom
Urgau:org-config

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Feb 18, 2026

This PR adds support for organization-wide default configuration, with rust-lang.triagebot.toml as the only one for now.

The default configuration takes the same options and features as normal triagebot.toml, with an optional excluded-repos = [] field to exclude some repos.

No default configuration has being added in the PR.

As discussed in #t-infra > Organization-wide triagebot.toml configuration

@Urgau Urgau requested a review from Kobzol February 18, 2026 18:29
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks simple enough (though macros 😿). That being said, I wonder if we should wait for the first use-case? Because replacing at the level of the top-level config might not be enough, i.e. we might want to also change some field of a specific config, and then this approach might have to be probably rewritten from scratch.

Do you have something specific in mind?

View changes since this review

@Urgau
Copy link
Member Author

Urgau commented Feb 19, 2026

I have some usecases, but I wanted to avoid mixing them up with the implementation PR.

Specifically I would like to enable org-wide:

  • view all comments link
  • range-diff
  • review changes since
  • transfer
  • concern?

Because replacing at the level of the top-level config might not be enough, i.e. we might want to also change some field of a specific config

Well, what is PR does, is that repo configs are respected and never overriden by the org-wide config. The repo config always has precedente.

As for specific field overriden, I don't see a usecase for now.

@Kobzol
Copy link
Member

Kobzol commented Feb 19, 2026

Ok, if you only have use-cases for replacing the top-level keys, that's fine by me 👍

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit commented above.

View changes since this review

@Urgau Urgau enabled auto-merge February 19, 2026 17:27
@Urgau Urgau added this pull request to the merge queue Feb 19, 2026
Merged via the queue into rust-lang:master with commit 94655a2 Feb 19, 2026
3 checks passed
@Urgau Urgau deleted the org-config branch February 19, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants