Add support for organization-wide default configuration#2292
Add support for organization-wide default configuration#2292Urgau merged 1 commit intorust-lang:masterfrom
Conversation
There was a problem hiding this comment.
The implementation looks simple enough (though macros 😿). That being said, I wonder if we should wait for the first use-case? Because replacing at the level of the top-level config might not be enough, i.e. we might want to also change some field of a specific config, and then this approach might have to be probably rewritten from scratch.
Do you have something specific in mind?
|
I have some usecases, but I wanted to avoid mixing them up with the implementation PR. Specifically I would like to enable org-wide:
Well, what is PR does, is that repo configs are respected and never overriden by the org-wide config. The repo config always has precedente. As for specific field overriden, I don't see a usecase for now. |
|
Ok, if you only have use-cases for replacing the top-level keys, that's fine by me 👍 |
This PR adds support for organization-wide default configuration, with
rust-lang.triagebot.tomlas the only one for now.The default configuration takes the same options and features as normal
triagebot.toml, with an optionalexcluded-repos = []field to exclude some repos.No default configuration has being added in the PR.
As discussed in #t-infra > Organization-wide triagebot.toml configuration