Fix comments rewritten too long

src/missed_spans.rs

@@ -263,7 +263,7 @@ impl<'a> FmtVisitor<'a> {
         };
 
         let comment_width = ::std::cmp::min(
-            self.config.comment_width(),
+            self.config.comment_width() - self.block_indent.width(),
             self.config.max_width() - self.block_indent.width(),
         );
         let comment_shape = Shape::legacy(comment_width, comment_indent);

tests/source/issue-5023.rs

@@ -1,22 +1,15 @@
 // rustfmt-wrap_comments: true
 
+// below we try and force a split at a byte in the middle of a multi-byte
+// character. The two parts of the first line are constructed such that:
+// 1) the entire line is longer than `$comment_width`
+// 2) the length of the second part is such that:
+//   `$comment_width - 3 + $length` is positive _and_ less than the number of
+//   bytes in the multi-byte char
+
+// xxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
+// 是
+
 /// A comment to test special unicode characters on boundaries
 /// 是，是，是，是，是，是，是，是，是，是，是，是  it should break right here this goes to the next line
-fn main() {
-    if xxx {
-        let xxx = xxx
-            .into_iter()
-            .filter(|(xxx, xxx)| {
-                if let Some(x) = Some(1) {
-                    // xxxxxxxxxxxxxxxxxx, xxxxxxxxxxxx, xxxxxxxxxxxxxxxxxxxx xxx xxxxxxx, xxxxx xxx
-                    // xxxxxxxxxx. xxxxxxxxxxxxxxxx，xxxxxxxxxxxxxxxxx xxx xxxxxxx
-                    // 是sdfadsdfxxxxxxxxx，sdfaxxxxxx_xxxxx_masdfaonxxx，
-                    if false {
-                        return true;
-                    }
-                }
-                false
-            })
-            .collect();
-    }
-}
+fn main() {}

tests/source/issue_6801.rs

@@ -0,0 +1,7 @@
+// rustfmt-wrap_comments: true
+
+fn foo() {
+    // this is a comment that could be broken right on max_comment and should break before that
+
+    ()
+}

tests/target/issue-5023.rs

@@ -1,23 +1,17 @@
 // rustfmt-wrap_comments: true
 
+// below we try and force a split at a byte in the middle of a multi-byte
+// character. The two parts of the first line are constructed such that:
+// 1) the entire line is longer than `$comment_width`
+// 2) the length of the second part is such that:
+//   `$comment_width - 3 + $length` is positive _and_ less than the number of
+//   bytes in the multi-byte char
+
+// xxxxxxxxxx
+// xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
+// 是
+
 /// A comment to test special unicode characters on boundaries
 /// 是，是，是，是，是，是，是，是，是，是，是，是  it should break right here
 /// this goes to the next line
-fn main() {
-    if xxx {
-        let xxx = xxx
-            .into_iter()
-            .filter(|(xxx, xxx)| {
-                if let Some(x) = Some(1) {
-                    // xxxxxxxxxxxxxxxxxx, xxxxxxxxxxxx, xxxxxxxxxxxxxxxxxxxx xxx xxxxxxx, xxxxx xxx
-                    // xxxxxxxxxx. xxxxxxxxxxxxxxxx，xxxxxxxxxxxxxxxxx xxx xxxxxxx
-                    // 是sdfadsdfxxxxxxxxx，sdfaxxxxxx_xxxxx_masdfaonxxx，
-                    if false {
-                        return true;
-                    }
-                }
-                false
-            })
-            .collect();
-    }
-}
+fn main() {}

tests/target/issue_6801.rs

@@ -0,0 +1,8 @@
+// rustfmt-wrap_comments: true
+
+fn foo() {
+    // this is a comment that could be broken right on max_comment and should
+    // break before that
+
+    ()
+}

tests/target/trailing_comments/hard_tabs.rs

@@ -18,10 +18,10 @@ fn lorem_ipsum() {
 	// nunc. Mauris consequat, enim vitae venenatis sollicitudin, dolor orci
 	// bibendum enim, a sagittis nulla nunc quis elit. Phasellus augue. Nunc
 	// suscipit, magna tincidunt lacinia faucibus, lacus tellus ornare purus, a
-	// pulvinar lacus orci eget nibh.  Maecenas sed nibh non lacus tempor faucibus.
-	// In hac habitasse platea dictumst. Vivamus a orci at nulla tristique
-	// condimentum. Donec arcu quam, dictum accumsan, convallis accumsan, cursus sit
-	// amet, ipsum.  In pharetra sagittis nunc.
+	// pulvinar lacus orci eget nibh.  Maecenas sed nibh non lacus tempor
+	// faucibus. In hac habitasse platea dictumst. Vivamus a orci at nulla
+	// tristique condimentum. Donec arcu quam, dictum accumsan, convallis
+	// accumsan, cursus sit amet, ipsum.  In pharetra sagittis nunc.
 	let b = baz();
 
 	let normalized = self.ctfont.all_traits().normalized_weight(); // [-1.0, 1.0]

tests/target/trailing_comments/soft_tabs.rs

@@ -18,10 +18,10 @@ fn foo() {
     // nunc. Mauris consequat, enim vitae venenatis sollicitudin, dolor orci
     // bibendum enim, a sagittis nulla nunc quis elit. Phasellus augue. Nunc
     // suscipit, magna tincidunt lacinia faucibus, lacus tellus ornare purus, a
-    // pulvinar lacus orci eget nibh.  Maecenas sed nibh non lacus tempor faucibus.
-    // In hac habitasse platea dictumst. Vivamus a orci at nulla tristique
-    // condimentum. Donec arcu quam, dictum accumsan, convallis accumsan, cursus sit
-    // amet, ipsum.  In pharetra sagittis nunc.
+    // pulvinar lacus orci eget nibh.  Maecenas sed nibh non lacus tempor
+    // faucibus. In hac habitasse platea dictumst. Vivamus a orci at nulla
+    // tristique condimentum. Donec arcu quam, dictum accumsan, convallis
+    // accumsan, cursus sit amet, ipsum.  In pharetra sagittis nunc.
     let b = baz();
 
     let normalized = self.ctfont.all_traits().normalized_weight(); // [-1.0, 1.0]

tests/target/unicode.rs

@@ -4,7 +4,8 @@ fn foo() {
     let s = "this line goes to 100: ͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶͶ";
     let s = 42;
 
-    // a comment of length 80, with the starting sigil: ҘҘҘҘҘҘҘҘҘҘ ҘҘҘҘҘҘҘҘҘҘҘҘҘҘ
+    // a comment of length 80, with the starting sigil: ҘҘҘҘҘҘҘҘҘҘ
+    // ҘҘҘҘҘҘҘҘҘҘҘҘҘҘ
     let s = 42;
 }