Fix (some) shellcheck lint errors#6598
Closed
GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
Closed
Fix (some) shellcheck lint errors#6598GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
Conversation
GuillaumeGomez
force-pushed
the
lint-errors
branch
from
ca0beed to
745b0c4
Compare
GuillaumeGomez
changed the title
GuillaumeGomez
force-pushed
the
lint-errors
branch
from
745b0c4 to
6e6f1a2
Compare
GuillaumeGomez
force-pushed
the
lint-errors
branch
from
6e6f1a2 to
1ba7940
Compare
Member
Author
|
I'm a bit confused by the errors, can't figure out if they come from my changes or not. Don't see where I could have mess things up though... |
Manishearth
approved these changes
Oct 9, 2025
jieyouxu
added
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
jieyouxu
reviewed
Mar 3, 2026
| local build=$(cargo test $test_args 2>&1) | ||
| if [[ "$build" =~ "build failed" ]] || [[ "$build" =~ "test result: FAILED." ]]; then | ||
| local build | ||
| # shellcheck is complaining that `$test_args` can be interpreted as multiple arguments |
Member
There was a problem hiding this comment.
Thought: we may want to run some version of ShellCheck in CI, but not for this PR.
Member
Author
|
Nah let's close this. From working on this PR, my main thought was mostly: "we should rewrite this in python or in Rust" as even the shell linters doesn't improve the code much (imo) and only highlight the complexity of the shell language. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening of rust-lang/rust#143512.
You can see the explanations for each lints fixed in the original PR.