only dump defaults for stable configs when running stable rustfmt#5597
Open
ytmimi wants to merge 1 commit intorust-lang:mainfrom
Open
only dump defaults for stable configs when running stable rustfmt#5597ytmimi wants to merge 1 commit intorust-lang:mainfrom
ytmimi wants to merge 1 commit intorust-lang:mainfrom
Conversation
Previously running rustfmt with `--print-config default` would always return a list of all config options and their default values. Now, when running the command on stable rustfmt we only return the default options for configs that have been marked as stable.
jieyouxu
added
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
jieyouxu
reviewed
Feb 27, 2026
Member
There was a problem hiding this comment.
The general notion looks good to me, but I suspect this might need to be updated since the PR is open since forever :D
@rustbot author
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5594
Previously running rustfmt with
--print-config defaultwould always return a list of all config options and their default values.Now, when running the command on stable rustfmt, we only return the default options for configs that have been marked as stable.