Show mean of primary/secondary results in GitHub summary comment tooltip#1907
Merged
Kobzol merged 1 commit intorust-lang:masterfrom May 14, 2024
Merged
Show mean of primary/secondary results in GitHub summary comment tooltip#1907Kobzol merged 1 commit intorust-lang:masterfrom
Kobzol merged 1 commit intorust-lang:masterfrom
Conversation
nnethercote
approved these changes
May 14, 2024
Contributor
nnethercote
left a comment
nnethercote
left a comment
There was a problem hiding this comment.
tooltip seems like a strange name. To me that means something that shows up when you hover over a GUI element. Maybe call it summary? Otherwise, LGTM.
Kobzol
force-pushed
the
gh-summary-tooltip
branch
from
9909bdc to
a316e6d
Compare
Member
Author
|
I also didn't like the name, but couldn't think of a better one. Summary is already kind of overloaded in the code, but it is a good name nevertheless. Changed the PR to use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance summary tables in GH comments (e.g. this one) show all metrics other than instruction count in a collapsed manner. I think that this sometimes leads to missing interesting information in these tables, if no one clicks on them.
This PR adds a short summary of the performance result to the
Resultsreveal button, so that it is clear how large is the effect even without clicking on the button. It should look like this: