Improve error when an .rlib can't be parsed#88368
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 8, 2021
Merged
Conversation
jyn514
added
A-metadata
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
Author
Member
Author
|
I would also be fine with making this a warning instead (a proper warning, using |
This comment has been minimized.
This comment has been minimized.
Contributor
|
It's been a while since I've looked at this, but I'm a little concerned about changing this to an error. There are some assumptions about invalid libraries, where they should be legitimately ignored. For example, there are race conditions in the pipelining system whereby I don't have much time to dig into this right now, but I'll try if petrochenkov doesn't get to it first. |
Contributor
|
I think metadata errors from this PR can use the same approach - stashed into new |
petrochenkov
added
S-waiting-on-author
Member
|
To copy my comment from #88351 (comment):
I originally intended the warn!() to be a user visible warning when I introduced it in #53470, but @alexcrichton had concerns that it would show up under normal usage when one rustc is loading metadata while another is writing an rlib. |
bjorn3
reviewed
Aug 27, 2021
Member
Author
I implemented this. |
jyn514
changed the title
warn! logging when an .rlib can't be parsed to a hard error
Member
Author
|
Err, I think I accidentally reused an existing error code. I'll add a new one. |
This comment has been minimized.
This comment has been minimized.
jyn514
added
S-waiting-on-review
bjorn3
reviewed
Aug 28, 2021
This comment has been minimized.
This comment has been minimized.
Collaborator
|
📌 Commit 93d8752a6469585e75312cf066f26b26dbad5679 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors r- |
bors
added
S-waiting-on-author
jyn514
force-pushed
the
metadata-error
branch
from
93d8752 to
254729c
Compare
Member
Author
|
@bors r=petrochenkov rollup=iffy |
Collaborator
|
📌 Commit 254729c29c240b24e54026c3a7fcbc19c078c194 has been approved by |
bors
removed
the
S-waiting-on-author
Collaborator
|
⌛ Testing commit 254729c29c240b24e54026c3a7fcbc19c078c194 with merge f74db595758d698dce486ce614b1191b460d364d... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
This usually describes either an error in the compiler itself or some
sort of IO error. Either way, we should report it to the user rather
than just saying "crate not found".
This only gives an error if the crate couldn't be loaded at all - if the
compiler finds another .rlib or .rmeta file which was valid, it will
continue to compile the crate.
Example output:
```
error[E0785]: found invalid metadata files for crate `foo`
--> bar.rs:3:24
|
3 | println!("{}", foo::FOO_11_49[0]);
| ^^^
|
= warning: failed to parse rlib '/home/joshua/test-rustdoc/libfoo.rlib': Invalid archive extended name offset
```
Member
Author
|
|
Member
Author
|
@bors r=petrochenkov rollup=iffy |
Collaborator
|
📌 Commit 257ac1b has been approved by |
Collaborator
|
⌛ Testing commit 257ac1b with merge 0432b5360a5eef87e52ca8fc679acbf8d5da176e... |
Collaborator
|
💔 Test failed - checks-actions |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Spurious? |
Contributor
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (5fa94f3): comparison url. Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
Member
Author
|
I suspect the regression is just because the new |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This usually describes either an error in the compiler itself or some
sort of IO error. Either way, we should report it to the user rather
than just saying "crate not found".
This only gives an error if the crate couldn't be loaded at all - if the
compiler finds another .rlib or .rmeta file which was valid, it will
continue to compile the crate.
Example output:
cc @ehuss