Place 2.0 change from enum to struct by spastorino · Pull Request #60913 · rust-lang/rust

spastorino · 2019-05-17T11:44:54Z

rust-highfive · 2019-05-17T12:03:35Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0a9a559a:start=1558093555781497353,finish=1558093645388304309,duration=89606806956
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:03:56] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:127: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:193: trailing whitespace
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:200: trailing whitespace
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:274: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:310: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:1468: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2170: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2287: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2323: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/borrow_check/error_reporting.rs:72: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:306: trailing whitespace
[00:03:57] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:321: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:317: trailing whitespace
[00:03:57] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:434: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:188: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:414: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:771: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:446: line longer than 100 chars
[00:03:57] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/mod.rs:257: trailing whitespace
[00:03:57] tidy error: /checkout/src/librustc/mir/tcx.rs:124: line longer than 100 chars
[00:04:02] some tidy checks failed
[00:04:02] 
[00:04:02] 
[00:04:02] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:02] 
[00:04:02] 
[00:04:02] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:02] Build completed unsuccessfully in 0:01:12
[00:04:02] Build completed unsuccessfully in 0:01:12
[00:04:02] Makefile:67: recipe for target 'tidy' failed
[00:04:02] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:030c9513
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 17 11:51:36 UTC 2019
---
travis_time:end:144a8464:start=1558093897710639669,finish=1558093897715228884,duration=4589215
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:15fb11aa
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05727e33
travis_time:start:05727e33
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:224c1513
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/librustc_mir/transform/uniform_array_move_out.rs

src/librustc_mir/transform/qualify_min_const_fn.rs

src/librustc_mir/transform/qualify_consts.rs

src/librustc_mir/borrow_check/error_reporting.rs

src/librustc_codegen_ssa/mir/place.rs

src/librustc_codegen_ssa/mir/operand.rs

bors · 2019-05-20T03:36:38Z

☔ The latest upstream changes (presumably #60969) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2019-05-23T12:32:17Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:04e32ecb:start=1558614264863172290,finish=1558614267013671483,duration=2150499193
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:48] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:127: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:193: trailing whitespace
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:200: trailing whitespace
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:274: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:310: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:1469: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2171: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2288: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2324: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/borrow_check/error_reporting.rs:72: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:71: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:77: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:306: trailing whitespace
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:321: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:314: trailing whitespace
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:429: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:188: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:411: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:768: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:443: line longer than 100 chars
[00:04:49] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/mod.rs:258: trailing whitespace
[00:04:49] tidy error: /checkout/src/librustc/mir/tcx.rs:124: line longer than 100 chars
[00:04:54] some tidy checks failed
[00:04:54] 
[00:04:54] 
[00:04:54] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:54] 
[00:04:54] 
[00:04:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:54] Build completed unsuccessfully in 0:01:14
[00:04:54] Build completed unsuccessfully in 0:01:14
[00:04:54] make: *** [tidy] Error 1
[00:04:54] Makefile:67: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2bee6a75
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu May 23 12:29:32 UTC 2019
---
travis_time:end:1330fae8:start=1558614573618322429,finish=1558614573624105285,duration=5782856
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00a56bc0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1ba5a54c
travis_time:start:1ba5a54c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:083fe03e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-05-23T13:04:58Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:2479aea4:start=1558615711197927597,finish=1558615713407791515,duration=2209863918
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:19] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:127: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:193: trailing whitespace
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:200: trailing whitespace
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:274: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:310: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:1469: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2171: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2288: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2324: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/borrow_check/error_reporting.rs:72: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:71: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:77: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:306: trailing whitespace
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:321: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:314: trailing whitespace
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:429: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:188: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:411: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:768: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:443: line longer than 100 chars
[00:04:19] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/mod.rs:258: trailing whitespace
[00:04:19] tidy error: /checkout/src/librustc/mir/tcx.rs:124: line longer than 100 chars
[00:04:24] some tidy checks failed
[00:04:24] 
[00:04:24] 
[00:04:24] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:24] 
[00:04:24] 
[00:04:24] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:24] Build completed unsuccessfully in 0:01:12
[00:04:24] Build completed unsuccessfully in 0:01:12
[00:04:24] Makefile:67: recipe for target 'tidy' failed
[00:04:24] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1dd41973
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu May 23 12:53:08 UTC 2019
---
travis_time:end:06083140:start=1558615989178166542,finish=1558615989182802075,duration=4635533
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:140e9714
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01d5a508
travis_time:start:01d5a508
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1a2b6120
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-05-24T05:57:47Z

☔ The latest upstream changes (presumably #60984) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2019-05-30T20:17:08Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:002139d8:start=1559246404000686180,finish=1559246412344056122,duration=8343369942
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:30] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:127: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:193: trailing whitespace
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:200: trailing whitespace
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:268: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/move_errors.rs:304: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:1471: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2288: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2324: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/conflict_errors.rs:75: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/borrow_check/conflict_errors.rs:607: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:71: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:77: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:306: trailing whitespace
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:321: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:314: trailing whitespace
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:429: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:188: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:411: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:768: line longer than 100 chars
[00:04:30] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:439: line longer than 100 chars
[00:04:31] tidy error: /checkout/src/librustc/mir/tcx.rs:124: line longer than 100 chars
[00:04:35] some tidy checks failed
[00:04:35] 
[00:04:35] 
[00:04:35] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:35] 
[00:04:35] 
[00:04:35] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:35] Build completed unsuccessfully in 0:01:13
[00:04:35] Build completed unsuccessfully in 0:01:13
[00:04:35] make: *** [tidy] Error 1
[00:04:35] Makefile:67: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:3b204910
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu May 30 20:04:59 UTC 2019
---
travis_time:end:0acc0b48:start=1559246700478490688,finish=1559246700483605795,duration=5115107
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0d8eeae0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:069d6c3b
travis_time:start:069d6c3b
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:13cb35fa
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-06-04T08:40:56Z

☔ The latest upstream changes (presumably #61510) made this pull request unmergeable. Please resolve the merge conflicts.

spastorino · 2019-06-06T17:42:58Z

I've just added some commits that are right now PRs waiting on bors and rebased this work on top of them, because this work need those. Once they are merged I'm going to rebase this PR on top of master again. Anyway, the important bit here is the WIP commit

rust-highfive · 2019-06-06T17:57:49Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1e899359:start=1559842902658856122,finish=1559843008334293571,duration=105675437449
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:15] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:15] tidy error: /checkout/src/librustc_codegen_ssa/mir/analyze.rs:172: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:122: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:188: trailing whitespace
[00:04:15] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:195: trailing whitespace
[00:04:15] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:1471: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2288: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2324: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/borrow_check/conflict_errors.rs:75: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/borrow_check/conflict_errors.rs:603: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:71: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:77: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:306: trailing whitespace
[00:04:15] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:321: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:414: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:188: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:412: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:769: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:439: line longer than 100 chars
[00:04:15] tidy error: /checkout/src/librustc/mir/tcx.rs:124: line longer than 100 chars
[00:04:20] some tidy checks failed
[00:04:20] 
[00:04:20] 
[00:04:20] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:20] 
[00:04:20] 
[00:04:20] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:20] Build completed unsuccessfully in 0:01:11
---
travis_time:end:05b96400:start=1559843279427846209,finish=1559843279432660417,duration=4814208
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1f9298b8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:06f29bb0
travis_time:start:06f29bb0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00b1a82d
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-06-06T23:42:21Z

☔ The latest upstream changes (presumably #61601) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2019-06-07T00:06:55Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:22ab8d0e:start=1559864878596378516,finish=1559864880806372211,duration=2209993695
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:41] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:41] tidy error: /checkout/src/librustc_codegen_ssa/mir/analyze.rs:172: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:122: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:188: trailing whitespace
[00:04:41] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:195: trailing whitespace
[00:04:41] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:1471: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2288: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2324: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/borrow_check/conflict_errors.rs:75: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/borrow_check/conflict_errors.rs:603: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:71: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:77: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:306: trailing whitespace
[00:04:41] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:321: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:414: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:188: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:412: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:769: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:439: line longer than 100 chars
[00:04:41] tidy error: /checkout/src/librustc/mir/tcx.rs:124: line longer than 100 chars
[00:04:46] some tidy checks failed
[00:04:46] 
[00:04:46] 
[00:04:46] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:46] 
[00:04:46] 
[00:04:46] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:46] Build completed unsuccessfully in 0:01:13
---
travis_time:end:0fdd694a:start=1559865179338363909,finish=1559865179343287397,duration=4923488
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00004870
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:25a52362
travis_time:start:25a52362
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:034a86cc
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-06-07T12:37:53Z

☔ The latest upstream changes (presumably #61209) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2019-06-07T13:53:50Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0ca5a572:start=1559914631302172299,finish=1559914633607876514,duration=2305704215
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:51] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:51] tidy error: /checkout/src/librustc_codegen_ssa/mir/analyze.rs:172: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:122: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:188: trailing whitespace
[00:04:51] tidy error: /checkout/src/librustc_mir/borrow_check/mutability_errors.rs:195: trailing whitespace
[00:04:51] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:1443: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2260: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/borrow_check/mod.rs:2296: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/borrow_check/conflict_errors.rs:75: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/borrow_check/conflict_errors.rs:603: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:71: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/transform/uniform_array_move_out.rs:77: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:306: trailing whitespace
[00:04:51] tidy error: /checkout/src/librustc_mir/transform/promote_consts.rs:321: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/transform/check_unsafety.rs:414: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:188: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:412: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/transform/qualify_consts.rs:769: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc_mir/dataflow/move_paths/builder.rs:439: line longer than 100 chars
[00:04:51] tidy error: /checkout/src/librustc/mir/tcx.rs:124: line longer than 100 chars
[00:04:56] some tidy checks failed
[00:04:56] 
[00:04:56] 
[00:04:56] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:56] 
[00:04:56] 
[00:04:56] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:56] Build completed unsuccessfully in 0:01:18
---
travis_time:end:2642d7b0:start=1559914940880960420,finish=1559914940889538955,duration=8578535
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:030aeaf2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ab9c8f4
travis_time:start:0ab9c8f4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2a108996
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk

preliminary review

src/librustc/mir/tcx.rs

src/librustc/mir/visit.rs

src/librustc_codegen_ssa/mir/analyze.rs

src/librustc_mir/borrow_check/mod.rs

src/librustc_mir/borrow_check/move_errors.rs

src/librustc/mir/visit.rs

bors · 2019-06-07T17:50:30Z

☔ The latest upstream changes (presumably #61622) made this pull request unmergeable. Please resolve the merge conflicts.

emilyalbini · 2019-07-20T12:20:10Z

@bors try

bors · 2019-07-20T12:20:23Z

⌛ Trying commit a8ceeeb with merge 0c7cf8c...

@oli-obk

Place 2.0 change from enum to struct r? @oli-obk

oli-obk · 2019-07-20T12:29:48Z

@rust-timer build 0c7cf8c

rust-timer · 2019-07-20T12:29:50Z

Success: Queued 0c7cf8c with parent f69b071, comparison URL.

oli-obk · 2019-07-20T12:31:04Z

src/librustc/mir/mod.rs

+        iterate_over2(place_base, place_projection, &Projections::Empty, op)
+    }
+
+    pub fn as_place_ref(&self) -> PlaceRef<'_, 'tcx> {


if it is deemed too wordy, I'm also fine with using as_ref. We can't use the AsRef trait though as that produces a reference

bors · 2019-07-20T14:46:05Z

☀️ Try build successful - checks-azure
Build commit: 0c7cf8c

rust-timer · 2019-07-20T17:10:36Z

Finished benchmarking try commit 0c7cf8c, comparison URL.

oli-obk · 2019-07-20T18:45:02Z

@bors r+ let's get this party (finally) started

bors · 2019-07-20T18:45:03Z

📌 Commit a8ceeeb has been approved by oli-obk

oli-obk · 2019-07-20T20:18:34Z

@bors p=42 bitrotty

bors · 2019-07-20T23:58:02Z

⌛ Testing commit a8ceeeb with merge 0dc2c40107950a79e92a79de33f1a4350bf80758...

Centril · 2019-07-21T00:24:17Z

@bors retry Yielding to #62797 which is a high-risk-if-not-landed-immediately-PR.

Centril · 2019-07-21T00:28:52Z

@bors rollup=never

bors · 2019-07-21T03:25:12Z

⌛ Testing commit a8ceeeb with merge 1301422...

@oli-obk

Place 2.0 change from enum to struct r? @oli-obk

bors · 2019-07-21T07:04:10Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 1301422 to master...

RalfJung · 2019-07-21T09:48:02Z

src/librustc/mir/mod.rs

 )]
 pub struct Projection<'tcx> {
-    pub base: Place<'tcx>,
+    pub base: Option<Box<Projection<'tcx>>>,


It is somewhat confusing to have base sometimes be a Projection and sometimes a PlaceBase.

Yes it is, but the entire Projection type will be gone soon, so I deemed it irrelevant

Changes: ```` Fix breakage due to rust-lang#60913 Fix breakage due to rust-lang#62705 rustup rust-lang#62679 Update pulldown-cmark to 0.5.3 rustup rust-lang#62764 Format code Decrease maximum length for stderr files Improved imports Fix "unkown clippy lint" error in UI test. Corrections for PR review. Implement lint for inherent to_string() method. UI Test Cleanup: Extract match_ref_pats tests Update UI tests Allow no_effect lint Remove comment cargo fmt UI Test Cleanup: Split up checked_unwrap tests Removed lintining on never type. UI Test Cleanup: Split out out_of_bounds_indexing false positives fixes of `implicit_return` ````

rust-highfive assigned oli-obk May 17, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2019

oli-obk reviewed May 17, 2019

View reviewed changes

spastorino force-pushed the place2_4 branch 2 times, most recently from c011eb9 to b75e1ed Compare May 23, 2019 12:23

spastorino force-pushed the place2_4 branch from b75e1ed to cee1d69 Compare May 23, 2019 12:47

spastorino force-pushed the place2_4 branch 2 times, most recently from d6ce5bf to 6f6f5a7 Compare May 30, 2019 19:59

spastorino force-pushed the place2_4 branch from 6f6f5a7 to 0c4ed32 Compare June 6, 2019 17:40

spastorino force-pushed the place2_4 branch from 0c4ed32 to 5ddbf63 Compare June 6, 2019 23:46

spastorino force-pushed the place2_4 branch from 5ddbf63 to ba84c6b Compare June 7, 2019 13:35

oli-obk requested changes Jun 7, 2019

View reviewed changes

oli-obk reviewed Jun 7, 2019

View reviewed changes

src/librustc_mir/borrow_check/move_errors.rs Outdated Show resolved Hide resolved

src/librustc_mir/borrow_check/move_errors.rs Outdated Show resolved Hide resolved

oli-obk reviewed Jun 7, 2019

View reviewed changes

src/librustc/mir/visit.rs Outdated Show resolved Hide resolved

spastorino force-pushed the place2_4 branch 2 times, most recently from 2c82f6d to 82b6f73 Compare June 7, 2019 20:24

emilyalbini closed this Jul 20, 2019

emilyalbini reopened this Jul 20, 2019

bors added a commit that referenced this pull request Jul 20, 2019

Auto merge of #60913 - spastorino:place2_4, r=<try>

0c7cf8c

Place 2.0 change from enum to struct r? @oli-obk

oli-obk reviewed Jul 20, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2019

bors added a commit that referenced this pull request Jul 21, 2019

Auto merge of #60913 - spastorino:place2_4, r=oli-obk

1301422

Place 2.0 change from enum to struct r? @oli-obk

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2019

bors merged commit a8ceeeb into rust-lang:master Jul 21, 2019

This was referenced Jul 21, 2019

Add a Use-Definition Chain implementation for the MIR. #62547

Closed

Polonius: fix some cases of killed fact generation, and most of the ui test suite #62736

Merged

RalfJung reviewed Jul 21, 2019

View reviewed changes

Uh oh!

Conversation

spastorino commented May 17, 2019

Uh oh!

rust-highfive commented May 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented May 20, 2019

Uh oh!

rust-highfive commented May 23, 2019

Uh oh!

rust-highfive commented May 23, 2019

Uh oh!

bors commented May 24, 2019

Uh oh!

rust-highfive commented May 30, 2019

Uh oh!

bors commented Jun 4, 2019

Uh oh!

spastorino commented Jun 6, 2019

Uh oh!

rust-highfive commented Jun 6, 2019

Uh oh!

bors commented Jun 6, 2019

Uh oh!

rust-highfive commented Jun 7, 2019

Uh oh!

bors commented Jun 7, 2019

Uh oh!

rust-highfive commented Jun 7, 2019

Uh oh!

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Jun 7, 2019

Uh oh!

emilyalbini commented Jul 20, 2019

Uh oh!

bors commented Jul 20, 2019

Uh oh!

oli-obk commented Jul 20, 2019

Uh oh!

rust-timer commented Jul 20, 2019

Uh oh!

oli-obk Jul 20, 2019

Choose a reason for hiding this comment

Uh oh!

bors commented Jul 20, 2019

Uh oh!

rust-timer commented Jul 20, 2019

Uh oh!

oli-obk commented Jul 20, 2019

Uh oh!

bors commented Jul 20, 2019

Uh oh!

oli-obk commented Jul 20, 2019

Uh oh!

bors commented Jul 20, 2019

Uh oh!

Centril commented Jul 21, 2019

Uh oh!