re-enable debuginfo/generic-enums-... lldb test#153149
Closed
shua wants to merge 1 commit intorust-lang:mainfrom
Closed
re-enable debuginfo/generic-enums-... lldb test#153149shua wants to merge 1 commit intorust-lang:mainfrom
shua wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This test was failing a while ago for lldb with some error related to > `NotImplementedError: Wrong number of arguments for overloaded function 'SBValue_GetChildAtIndex'.` When I run the test, it no longer outputs this error. This change removes the `ignore-lldb: FIXME` line and adds this test back. It seems the `v var` command now has a slightly different output, so I've updated the corresponding `lldb-check` lines as well.
Author
|
This may be blocked for similar reasons as #141539 , but I wouldn't say I understand it well enough to say. |
Member
|
Yeah, I'm not inclined to enable specific LLDB tests that don't get run in CI anyway right now. So going to close this. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was failing a while ago for lldb with some error related to
When I run the test, it no longer outputs this error.
This change removes the
ignore-lldb: FIXME(27089)line and adds this test back. It seems thev varcommand now has a slightly different output, so I've updated the correspondinglldb-checklines as well.fixes #27089