Skip to content

Revert "rustc_expand: improve diagnostics for non-repeatable metavars"#153095

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
JonathanBrouwer:revert
Feb 26, 2026
Merged

Revert "rustc_expand: improve diagnostics for non-repeatable metavars"#153095
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
JonathanBrouwer:revert

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Feb 25, 2026 •
edited
Loading

Revert because of a perf regression in #152679
Clean revert

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 25, 2026
Merged
lqd
lqd approved these changes Feb 25, 2026
View reviewed changes
Copy link
Member

@lqd lqd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, r=me

View changes since this review

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 25, 2026

@bors r=lqd rollup=never

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 25, 2026

📌 Commit fe3b3a4 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2026
@jieyouxu jieyouxu mentioned this pull request Feb 26, 2026
Open
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 26, 2026

@bors p=1
Would be nice include this major perf regression revert in the beta

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 26, 2026

@bors rollup=iffy
DO NOT ROLL THIS UP WITH ANYTHING OTHER THAN DISCUSSED HERE
#t-infra > Tree ops @ 💬

@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 26, 2026
Merged
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 26, 2026

@bors p=5 to match the other revert

rust-bors bot pushed a commit that referenced this pull request Feb 26, 2026
@bors
Auto merge of #153139 - JonathanBrouwer:rollup-QZ4yuaa, r=JonathanBro…
25396cf 
…uwer

Rollup of 2 pull requests

Successful merges:

 - #153055 ( Revert "Also duplicate `#[expect]` attribute in `#[derive]`-ed code")
 - #153095 (Revert "rustc_expand: improve diagnostics for non-repeatable metavars")
@rust-bors rust-bors bot merged commit 3e1566d into rust-lang:main Feb 26, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Feb 26, 2026
@rust-timer
Unrolled build for #153095
0a9deae 
Rollup merge of #153095 - JonathanBrouwer:revert, r=lqd

Revert "rustc_expand: improve diagnostics for non-repeatable metavars"

Revert because of a perf regression in #152679
Clean revert

r? @ghost
@rustbot rustbot added this to the 1.95.0 milestone Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd approved these changes

Assignees

No one assigned

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JonathanBrouwer @lqd @rustbot