Implement debuginfo for unsafe binder types#153017
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 25, 2026
Merged
Implement debuginfo for unsafe binder types#153017rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-LLVM
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
makai410
commented
Feb 23, 2026
| if cpp_like_debuginfo { | ||
| output.push_str("unsafe$<"); | ||
| } else { | ||
| output.push_str("unsafe "); |
Member
Author
There was a problem hiding this comment.
Not sure what the type name should be here...
This comment has been minimized.
This comment has been minimized.
makai410
force-pushed
the
di-unsafe-binder
branch
from
59e7a3b to
b608343
Compare
wesleywiser
approved these changes
Feb 24, 2026
| if cpp_like_debuginfo { | ||
| output.push_str("unsafe$<"); | ||
| } else { | ||
| output.push_str("unsafe "); |
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 24, 2026
…ywiser Implement debuginfo for unsafe binder types Fixes: rust-lang#139462 This treats an unsafe binder like a struct with a single field. This way we'd have the binder's distinct type name while keeping the wrapped value accessible. Tracking: - rust-lang#130516
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
Rollup of 8 pull requests Successful merges: - #149169 (ptr::replace: make calls on ZST null ptr not UB) - #150562 (Fix doc link used in suggestion for pinning self) - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars) - #153017 (Implement debuginfo for unsafe binder types) - #152868 (delete some very old trivial `Box` tests) - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153051 (Migration of `LintDiagnostic` - part 3)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
Rollup of 12 pull requests Successful merges: - #149169 (ptr::replace: make calls on ZST null ptr not UB) - #150562 (Fix doc link used in suggestion for pinning self) - #152418 (`BTreeMap::merge` optimized) - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars) - #152952 (mGCA: improve ogca diagnostic message ) - #152977 (Fix relative path handling for --extern-html-root-url) - #153017 (Implement debuginfo for unsafe binder types) - #152868 (delete some very old trivial `Box` tests) - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`) - #153032 (Fix attribute parser and kind names.) - #153051 (Migration of `LintDiagnostic` - part 3) - #153060 (Give a better error when updating a submodule fails)
rust-timer
added a commit
that referenced
this pull request
Feb 25, 2026
Rollup merge of #153017 - makai410:di-unsafe-binder, r=wesleywiser Implement debuginfo for unsafe binder types Fixes: #139462 This treats an unsafe binder like a struct with a single field. This way we'd have the binder's distinct type name while keeping the wrapped value accessible. Tracking: - #130516
Member
|
@rust-timer build 6051e59 For #153074. |
Collaborator
|
Missing artifact for sha |
Contributor
|
@rust-timer build 6051e59 |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (6051e59): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -5.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.6%, secondary -1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 482.035s -> 479.239s (-0.58%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #139462
This treats an unsafe binder like a struct with a single field. This way we'd have the binder's distinct type name while keeping the wrapped value accessible.
Tracking: