Add new unstable attribute: #[export_visibility = ...].#151431
Open
anforowicz wants to merge 3 commits intorust-lang:mainfrom
Open
Add new unstable attribute: #[export_visibility = ...].#151431anforowicz wants to merge 3 commits intorust-lang:mainfrom
#[export_visibility = ...].#151431anforowicz wants to merge 3 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-compiler
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
Member
|
i had a quick look, mostly looks good, but i'd like to maybe @JonathanBrouwer take a look on this as well, i may overlooked something r? JonathanBrouwer |
Contributor
|
Would like to take a look, will do so tomorrow :) |
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
requested changes
Jan 21, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
3 tasks
tgross35
reviewed
Jan 22, 2026
tgross35
reviewed
Jan 22, 2026
anforowicz
force-pushed
the
export-visibility
branch
from
2043b51 to
8dc8f60
Compare
This comment has been minimized.
This comment has been minimized.
anforowicz
force-pushed
the
export-visibility
branch
from
8dc8f60 to
6ccbf57
Compare
anforowicz
force-pushed
the
export-visibility
branch
3 times, most recently
from
88ddd87 to
a741ebc
Compare
tgross35
reviewed
Jan 27, 2026
anforowicz
force-pushed
the
export-visibility
branch
from
a741ebc to
aa26225
Compare
This comment has been minimized.
This comment has been minimized.
anforowicz
force-pushed
the
export-visibility
branch
from
8a51a4b to
6441282
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-review
Contributor
Author
Thanks for the feedback! I update the PR to ignore Wasm targets in the new rmake test. |
This comment has been minimized.
This comment has been minimized.
anforowicz
force-pushed
the
export-visibility
branch
from
1cb6478 to
56b4291
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
anforowicz
force-pushed
the
export-visibility
branch
from
56b4291 to
b12629f
Compare
Contributor
Author
I hope this means that it is okay if I do: @bors r+ rollup=iffy |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 27, 2026
…forowicz Add new unstable attribute: `#[export_visibility = ...]`. This PR is an implementation of the RFC tracked in rust-lang#151425
Contributor
|
@bors r=JonathanBrouwer |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 27, 2026
…nathanBrouwer Add new unstable attribute: `#[export_visibility = ...]`. This PR is an implementation of the RFC tracked in rust-lang#151425
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…uwer Rollup of 11 pull requests Successful merges: - #151431 (Add new unstable attribute: `#[export_visibility = ...]`.) - #153012 (Stop using `LinkedGraph` in `lexical_region_resolve`) - #153179 (Force a CI LLVM stamp bump) - #150828 (Improved security section in rustdoc for `current_exe`) - #152673 (rustc_public: rewrite `bridge_impl` to reduce boilerplate) - #152674 (rustc_public: remove the `CrateDefItems` trait) - #153073 (Fix mem::conjure_zst panic message to use any::type_name instead) - #153117 (Remove mutation from macro path URL construction) - #153128 (Recover feature lang_items for emscripten) - #153138 (Print path root when printing path) - #153159 (Work around a false `err.emit();` type error in rust-analyzer)
Contributor
rust-bors
bot
added
S-waiting-on-author
Contributor
Contributor
|
@bors delegate- |
Contributor
Author
|
There have been 3 failures mentioned in #153171 (comment). All the failures seem underneath the new
|
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
This PR is an implementation of the RFC tracked in #151425