Replace visibility test with reachability test in dead code detection by krtab · Pull Request #119552 · rust-lang/rust

krtab · 2024-01-03T16:48:38Z

Fixes #119545

Also included is a fix for an error now flagged by the lint

rustbot · 2024-01-03T16:48:47Z

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_passes/src/dead.rs

krtab · 2024-01-04T15:22:28Z

Hm, my bad it took me some time to figure out why things were compiling on my side but not in the CI. I'll fix all the previously undetected dead code and you can review then.

@rustbot author

rustbot · 2024-01-04T16:34:08Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

compiler/rustc_codegen_gcc/src/context.rs

rustbot · 2024-01-05T15:25:10Z

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

flip1995

Commit fb75654 is kinda a 🥷 fix for Clippy and doesn't really belong in this PR. I definitely appreciate the fix, but would prefer to have it in a Clippy PR. What's the motivation in including it in this PR?

src/tools/clippy/tests/ui-toml/needless_raw_string_hashes_one_allowed/clippy.toml

krtab · 2024-01-05T16:29:29Z

Commit fb75654 is kinda a 🥷 fix for Clippy and doesn't really belong in this PR. I definitely appreciate the fix, but would prefer to have it in a Clippy PR. What's the motivation in including it in this PR?

I hesitated and discussed with other contributors to Rust. My issue with having it in a clippy specific PR is that I don't have a good solution to pass the CI in this one. I can delete or mark as allow(dead_code) the unused fields here and make the more substantial fix in clippy itself, but then this requires a correct ordering between this PR merge and the update of the in-tree clippy.
Having the fix here avoids having to PR to synchronize.

flip1995 · 2024-01-05T16:38:44Z

Ah, was the self.allow_one_hash_in_raw_strings field unused? Well then, let's keep it in this PR. Thanks for the explanation!

rustbot · 2024-01-05T17:17:51Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

krtab · 2024-01-08T16:27:57Z

Well it seems to finally pass the CI! Didn't expect it to end-up being a +120/-51 PR 😅
I expect that there will be breakage during bors try.

Anyway @rustbot review

krtab · 2024-03-22T09:05:01Z

@rustbot author

Noratrieb · 2024-03-22T09:47:13Z

the failure may be spurious
@bors retry

Noratrieb · 2024-03-22T09:47:35Z

oh wait no you modified CI
@bors r
if you revert that I can retry

Noratrieb · 2024-03-22T09:47:54Z

@bors r-

src/bootstrap/src/core/build_steps/compile.rs

saethlin · 2024-03-22T12:12:54Z

Suggestion (or argue that my suggestion is a bad idea), then I'll re-apply approval.

saethlin · 2024-03-22T12:33:08Z

@bors r=cjgillot,saethlin

bors · 2024-03-22T12:33:10Z

📌 Commit 843e79f has been approved by cjgillot,saethlin

It is now in the queue for this repository.

bors · 2024-03-22T15:01:58Z

⌛ Testing commit 843e79f with merge 1cb1dca...

bors · 2024-03-22T16:48:51Z

💔 Test failed - checks-actions

krtab · 2024-03-22T18:22:17Z

@rustbot author

I need to find a way to compile src/bootstrap locally with the stage1 compiler to get rid of all errors befors re pushing.

The dead_code lint was previously eroneously missing this dead code. Since this lint bug has been fixed, the unused field need to be removed or marked as `#[allow(dead_code)]`. Given that this struct is deserialized without #[serde(deny_unknown_fields)] it is ok to simply delete the never read fields.

krtab · 2024-03-22T23:04:55Z

@rustbot review

saethlin · 2024-03-22T23:46:49Z

@bors r=cjgillot,saethlin

bors · 2024-03-22T23:46:50Z

📌 Commit 7342cc4 has been approved by cjgillot,saethlin

It is now in the queue for this repository.

workingjubilee · 2024-03-23T00:06:43Z

higher!
@bors p=2

bors · 2024-03-23T00:37:09Z

⌛ Testing commit 7342cc4 with merge c308726...

bors · 2024-03-23T02:39:54Z

☀️ Test successful - checks-actions
Approved by: cjgillot,saethlin
Pushing c308726 to master...

rust-timer · 2024-03-23T03:54:25Z

Finished benchmarking commit (c308726): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[1.0%, 3.2%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[1.0%, 3.2%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.1%, 3.7%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[2.1%, 3.7%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[1.4%, 3.7%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[1.4%, 3.7%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.121s -> 671.167s (0.01%)
Artifact size: 315.04 MiB -> 315.03 MiB (-0.00%)

krtab · 2024-03-23T12:03:06Z

Thanks everyone, especially @cjgillot and @saethlin :)

Kobzol · 2024-03-23T13:38:40Z

More warnings are now emitted for ripgrep (analyzed here).

@rustbot label: +perf-regression-triaged

rustbot assigned cjgillot Jan 3, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 3, 2024

This comment has been minimized.

Sign in to view

cjgillot reviewed Jan 3, 2024

View reviewed changes

compiler/rustc_passes/src/dead.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2024

krtab force-pushed the dead_code_priv_mod_pub_field branch from 3e34b88 to e6d8c78 Compare January 4, 2024 15:54

This comment has been minimized.

Sign in to view

krtab force-pushed the dead_code_priv_mod_pub_field branch from e6d8c78 to 4521396 Compare January 4, 2024 16:34

antoyo reviewed Jan 4, 2024

View reviewed changes

compiler/rustc_codegen_gcc/src/context.rs Show resolved Hide resolved

antoyo reviewed Jan 4, 2024

View reviewed changes

compiler/rustc_codegen_gcc/src/context.rs Show resolved Hide resolved

krtab force-pushed the dead_code_priv_mod_pub_field branch from 4521396 to 549f08f Compare January 4, 2024 16:49

This comment has been minimized.

Sign in to view

krtab force-pushed the dead_code_priv_mod_pub_field branch from 549f08f to 73be48a Compare January 5, 2024 15:25

This comment has been minimized.

Sign in to view

flip1995 reviewed Jan 5, 2024

View reviewed changes

src/tools/clippy/tests/ui-toml/needless_raw_string_hashes_one_allowed/clippy.toml Outdated Show resolved Hide resolved

krtab force-pushed the dead_code_priv_mod_pub_field branch from 73be48a to 5be1860 Compare January 5, 2024 17:17

rustbot added the O-unix Operating system: Unix-like label Jan 5, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2024

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2024

This comment has been minimized.

Sign in to view

saethlin reviewed Mar 22, 2024

View reviewed changes

src/bootstrap/src/core/build_steps/compile.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

dtolnay mentioned this pull request Mar 24, 2024

Suppress dead code lint on custom token's span field dtolnay/syn#1602

Merged

Amanieu mentioned this pull request Mar 31, 2024

Stabilize AArch64 SHA3 intrinsics rust-lang/stdarch#1552

Merged

chinedufn mentioned this pull request Jun 19, 2024

Fix dead_code warning when returning Result with bridged type in error case chinedufn/swift-bridge#278

Merged

Uh oh!

Conversation

krtab commented Jan 3, 2024

Uh oh!

rustbot commented Jan 3, 2024

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

krtab commented Jan 4, 2024

Uh oh!

This comment has been minimized.

rustbot commented Jan 4, 2024

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Jan 5, 2024

Uh oh!

This comment has been minimized.

flip1995 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

krtab commented Jan 5, 2024

Uh oh!

flip1995 commented Jan 5, 2024

Uh oh!

rustbot commented Jan 5, 2024

Uh oh!

This comment has been minimized.

krtab commented Jan 8, 2024

Uh oh!

krtab commented Mar 22, 2024

Uh oh!

Noratrieb commented Mar 22, 2024

Uh oh!

Noratrieb commented Mar 22, 2024

Uh oh!

Noratrieb commented Mar 22, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

saethlin commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saethlin commented Mar 22, 2024

Uh oh!

bors commented Mar 22, 2024

Uh oh!

bors commented Mar 22, 2024

Uh oh!

This comment has been minimized.

bors commented Mar 22, 2024

Uh oh!

krtab commented Mar 22, 2024

Uh oh!

krtab commented Mar 22, 2024

Uh oh!

saethlin commented Mar 22, 2024

Uh oh!

bors commented Mar 22, 2024

Uh oh!

workingjubilee commented Mar 23, 2024

Uh oh!

bors commented Mar 23, 2024

Uh oh!

bors commented Mar 23, 2024

Uh oh!

rust-timer commented Mar 23, 2024

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

krtab commented Mar 23, 2024

Uh oh!

flip1995 left a comment •

edited

Loading

saethlin commented Mar 22, 2024 •

edited

Loading