Skip to content

Fix semicolon-inside-block inside try_blocks#16697

Merged
dswij merged 1 commit intorust-lang:masterfrom
Taym95:fix-semicolon-inside-block-inside-try_blocks
Mar 9, 2026
Merged

Fix semicolon-inside-block inside try_blocks#16697
dswij merged 1 commit intorust-lang:masterfrom
Taym95:fix-semicolon-inside-block-inside-try_blocks

Conversation

@Taym95
Copy link
Contributor

@Taym95 Taym95 commented Mar 9, 2026

fixes #16696

changelog: [semicolon_inside_block]: fix false positive in try blocks where moving ; inside changes the block's return type and causes type errors.

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 9, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dswij dswij added this pull request to the merge queue Mar 9, 2026
Merged via the queue into rust-lang:master with commit 5e1d741 Mar 9, 2026
11 of 13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

semicolon-inside-block does not like try_blocks

3 participants