Fix is_cfg_test to handle all(test, ...) cfg attributes#16684
Open
Bortlesboat wants to merge 1 commit intorust-lang:masterfrom
Open
Fix is_cfg_test to handle all(test, ...) cfg attributes#16684Bortlesboat wants to merge 1 commit intorust-lang:masterfrom
Bortlesboat wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
`is_cfg_test` only matched `CfgEntry::NameValue { name: test }` at the
top level, so `#[cfg(all(test))]` and `#[cfg(all(test, ...))]` were not
recognized as test cfg. Recurse into `CfgEntry::All` variants.
Bortlesboat
force-pushed
the
fix-cfg-test-complex-attrs
branch
2 times, most recently
from
158233d to
3041552
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16476
is_cfg_testonly matched top-levelCfgEntry::NameValue { name: test }, so#[cfg(all(test))]and#[cfg(all(test, not(...)))]were not recognized as test configurations. This adds a recursive check intoCfgEntry::Allvariants.changelog: [
tests_outside_test_module]: fix false positive when using#[cfg(all(test, ...))]Test plan
#[cfg(all(test))]and#[cfg(all(test, not(target_pointer_width = "16")))]