manual_pop_if: lint more cases, even if we do not provide a suggestion

[pbor]

Extend the lint to detect the case where the popped value is used, but in such cases just emit the lint with no suggestion.

changelog: none

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq, samueltardieu

[pbor]

r? @ada4a

This is a follow up to #16582

I did not include the changelog since the new lint was just added and that will be in the changelog

[ada4a]

Some tentative review

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[ada4a]

I did not include the changelog since the new lint was just added and that will be in the changelog

In that case, changelog: none is still required^^

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[pbor]

Thanks for the review and suggestions, PR updated.

[pbor]

@rustbot ready

[ada4a]

Hm, it didn't come out as nice as I'd imagined – it's a bit too verbose. Let me play around with it locally and get back to you when I find something nicer

[ada4a]

Hm, nevermind, I think the original version was the best after all. Could you please revert to that?^^