fix(explicit_counter_loop): suggest .take(n) for for _ in 0..n co…#16658
Open
zayutaha wants to merge 1 commit intorust-lang:masterfrom
Open
fix(explicit_counter_loop): suggest .take(n) for for _ in 0..n co…#16658zayutaha wants to merge 1 commit intorust-lang:masterfrom
.take(n) for for _ in 0..n co…#16658zayutaha wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
ae45101 to
6fe961a
Compare
Jarcho
reviewed
Mar 4, 2026
| if pat_snippet == "_" | ||
| && let Some(range) = Range::hir(cx, arg) | ||
| && range.limits == RangeLimits::HalfOpen | ||
| && range.start.is_none_or(|start| is_integer_const(cx, start, 0)) |
Contributor
There was a problem hiding this comment.
Why is_none_or? RangeTo isn't iterable in the first place.
Author
There was a problem hiding this comment.
Thanks for the suggestion! The zero check is still needed though — without it, for _ in 5..MAX would incorrectly suggest (init..).take(MAX), which runs MAX times instead of the correct MAX - 5 times. I've added test cases for both non-zero start and inclusive ranges to cover this.
6fe961a to
07123db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a loop variable is unused (
for _ in 0..n) and the counter is beingincremented, Clippy previously suggested the generic zip-based rewrite.
This PR adds a more idiomatic
.take(n)suggestion for the common casewhere the range is half-open and starts at zero:
Non-zero starts (
5..MAX) and inclusive ranges (0..=MAX) areexplicitly excluded and fall through to the existing zip suggestion.
Both cases are covered by new UI tests.
changelog: [
explicit_counter_loop]: suggest(init..).take(n)when loop variable is unused and range is0..nfixes #16642