clippy_dev parsing revamp part 7/N#16645
Open
Jarcho wants to merge 13 commits intorust-lang:masterfrom
Open
Conversation
Jarcho
added
the
S-blocked
Collaborator
|
Some changes occurred in clippy_lints/src/doc cc @notriddle |
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Jarcho
force-pushed
the
dev_parse7
branch
2 times, most recently
from
4ce53ef to
b09d5df
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
☔ The latest upstream changes (possibly #16668) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #16644
All but the last commit are minor cleanups. The last commit is larger and adds significantly nicer error reporting. This is a huge QOL improvement when dealing with parsing failures. I'll also be using this for some internal cross crate linting since clippy proper isn't capable of those.
changelog: none