Use #[must_use] determination from the compiler#16633
Draft
samueltardieu wants to merge 1 commit intorust-lang:masterfrom
Draft
Use #[must_use] determination from the compiler#16633samueltardieu wants to merge 1 commit intorust-lang:masterfrom
#[must_use] determination from the compiler#16633samueltardieu wants to merge 1 commit intorust-lang:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
features/must-use-from-compiler
branch
from
35d95f3 to
7392cc1
Compare
|
Lintcheck changes for e083a22
This comment will be updated if you push new changes |
samueltardieu
force-pushed
the
features/must-use-from-compiler
branch
from
7392cc1 to
e083a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: better determination of
#[must_use]needs by directly using the compiler algorithmThis still needs some work to provide better error message in the case of the
double_must_uselint: users might not know that some types such asBoxwill forward the#[must_use]status form their payload.