Use contiguous spans for empty_line_after_* suggestion

[flip1995]

Replacing an empty span (which an empty line is) with an empty string triggers a debug assertion in rustc. This fixes the debug assertion by using contiguous spans, with the same resulting suggestion.

r? @Alexendoo

This unblocks the sync

changelog: none

[Alexendoo]

Ah sorry I didn't see that rust-lang/rust#129991 was a direct mention rather than a team one, feel free to poke me on zulip if that happens again

Looks like I missed a test case for it but this would remove the comment in e.g.

#[allow(unused)]

// comment

fn main() {}

To unblock the sync we could turn it into a regular .help() message and look at solving it separately, may need to disable rustfix for the tests

[flip1995]

Good catch. I added the test and fixed the issue. It's now a bit more complicated. If you have a better idea how to do this, let me know.

[Alexendoo]

https://docs.rs/itertools/latest/itertools/trait.Itertools.html#method.chunk_by + .map could work here but I haven't tried it

[flip1995]

Good idea! Makes the code way cleaner.

[Alexendoo]

👍

@bors r+

[bors]

📌 Commit 7f30daf has been approved by Alexendoo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7f30daf with merge b7ab258...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing b7ab258 to master...