Use core::error::Error instead of std::error::Error#1334
Open
ppentchev wants to merge 1 commit intorust-lang:masterfrom
Open
Use core::error::Error instead of std::error::Error#1334ppentchev wants to merge 1 commit intorust-lang:masterfrom
ppentchev wants to merge 1 commit intorust-lang:masterfrom
Conversation
Author
|
...sorry, I just realized why it was this way - at the very least since |
Member
|
I'm actually okay with doing the MSRV bump necessary for this impl. I was actually thinking of bumping to Rust 1.85 and doing a migration to Rust 2024. |
Member
|
But yes, MSRV is why this hasn't been done until now. |
...and let all error types derive from it even in no-std mode.
ppentchev
force-pushed
the
pp-core-error
branch
from
e0576ce to
3addb68
Compare
Author
Hah, that would be great! Do you want me to also bump MSRV as part of this PR, or would you prefer to do it separately, in a different change, etc? |
Member
|
I can do that in a separate change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks a lot for writing and maintaining the regex crate!
What do you think about this change that makes all the error types derive
core::error::Errorinstead ofstd::error::Errorso that they are usable even inno-stdmode? There are several error handling crates likeanyhow,eyre, etc. which also work inno-stdmode, and they refuse to accept the error objects defined in these crates then.Thanks in advance, and keep up the great work!
G'luck,
Peter