-
Notifications
You must be signed in to change notification settings - Fork 577
cfg_select! macro
#2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
folkertdev
wants to merge
11
commits into
rust-lang:master
Choose a base branch
from
folkertdev:cfg-select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
cfg_select! macro
#2103
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b4ef15d
`cfg_select!` macro
folkertdev 8a3349a
more detail
folkertdev adda479
Add more correct grammar for `cfg_select!`
traviscross 4cdb225
Update src/conditional-compilation.md
folkertdev e3fb956
Rework the cfg_select intro
ehuss 1637914
Add specific rules for cfg_select behavior
ehuss 6712d5d
Simplify wording of cfg.cfg_select.wildcard
ehuss 032f9ab
Remove cfg.cfg_select.positions
ehuss a824e61
Simplify wording of cfg.cfg_select.fallthrough
ehuss 11e5d04
Improve wording of cfg.cfg_select.well-formed
ehuss 5c1d0c5
Fix sorting of cfg_select! link definition
ehuss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This grammar doesn't quite look correct to me.
Some comments:
`cfg_select!` `{` … `}`because the braces can also be()or[](also!is a separate token), and the macro name can be renamed. I would suggest just documenting what the input to the macro is, and not the surrounding invocation syntax.,behavior.I'm thinking the grammar would be something closer to:
Where the X expressions are from the Expression grammar, but without the outer attributes. If this is correct, we'll need to rework
Expressionto support that.Does that make sense?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though looking again, my suggestion above won't work because we are moving towards a grammar that does not have infinite lookahead for disambiguation. So the
LastCfgSelectBranchwon't work. I offhand can't think of a way to actually express that...(Maybe lookahead is required?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed something that might be closer.