Skip to content

Conversation

@MousseARaser06
Copy link

@MousseARaser06 MousseARaser06 commented Feb 1, 2026

This pull request aims at fixing #4352, it proceeds by having a list of platform-allowed flags (bits) for that operation (F_SETFL), and performing a bitwise AND assignment to exclude all of the flags that aren't allowed.
Allowed flags change from platform to platform

@rustbot
Copy link
Collaborator

rustbot commented Feb 1, 2026

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Feb 1, 2026
@RalfJung
Copy link
Member

RalfJung commented Feb 2, 2026

Thanks for the PR :)

We'll get to reviewing it eventually, but there are other PRs in the queue that will be reviewed first.

@MousseARaser06 MousseARaser06 force-pushed the fcntl_fsetfl_ignore_flags branch from a940c59 to 9291577 Compare February 7, 2026 20:55
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Waiting for a review to complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants