use #[naked] as an unsafe attribute#817
Merged
tgross35 merged 1 commit intorust-lang:masterfrom Apr 16, 2025
Merged
Conversation
Contributor
|
Would it be possible for rustc to accept both forms until this gets updated, to bootstrap this? Unfortunately I don't know if we could merge and release this with the failures here. Another case where a subtree would be nice... Edit: I see rust-lang/rust#139797 now |
Contributor
Author
|
Right, yeah not ideal but we'll make it work. This PR will then likely needs some |
Contributor
Author
|
Allright, this works now that rust-lang/rust#139797 is in nightly. After merging this, I guess the next step is to create a release of |
tgross35
approved these changes
Apr 16, 2025
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Apr 16, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [1]: rust-lang/compiler-builtins#817
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Apr 17, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
folkertdev
pushed a commit
to folkertdev/rust
that referenced
this pull request
Apr 17, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2025
Rollup merge of rust-lang#139934 - tgross35:update-builtins, r=tgross35 Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Apr 19, 2025
Update `compiler-builtins` to 0.1.155 Includes the following changes: * Replace `#[naked]` with `#[unsafe(naked)]` [1] [2] * Replace `bl!` with `asm_sym` [3] [1]: rust-lang/compiler-builtins#817 [2]: rust-lang/compiler-builtins#821 [3]: rust-lang/compiler-builtins#820 try-job: armhf-gnu try-job: aarch64-apple try-job: dist-apple-various
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per rust-lang/rust#134213 (comment), we want to make the
#[naked]attribute an unsafe attribute.Based on the CI failures here rust-lang/rust#139753, I believe that
compiler-builtinsneed to be updated first.