min,max: Add tests for signaling NaNs and update documentation#1104
Open
tgross35 wants to merge 4 commits intorust-lang:mainfrom
Open
min,max: Add tests for signaling NaNs and update documentation#1104tgross35 wants to merge 4 commits intorust-lang:mainfrom
tgross35 wants to merge 4 commits intorust-lang:mainfrom
Conversation
tgross35
force-pushed
the
min-max-snan
branch
2 times, most recently
from
1a2894f to
30bbb34
Compare
Contributor
Author
|
Cc @RalfJung |
tgross35
force-pushed
the
min-max-snan
branch
2 times, most recently
from
73da7c9 to
5fa14cd
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Mar 6, 2026
libm/src/math/generic/fmaximum.rs
Outdated
| //! - qNaN if either operation is NaN | ||
| //! | ||
| //! Excluded from our implementation is sNaN handling. | ||
| //! Note that the IEEE 754-2019 specifies that a sNaN in eitt her argument should signal invalid, |
Member
There was a problem hiding this comment.
Suggested change
| //! Note that the IEEE 754-2019 specifies that a sNaN in eitt her argument should signal invalid, | |
| //! Note that the IEEE 754-2019 specifies that a sNaN in either argument should signal invalid, |
happens a few times
tgross35
force-pushed
the
min-max-snan
branch
3 times, most recently
from
09291aa to
68b91db
Compare
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
min-max-snan
branch
5 times, most recently
from
5d9b1bf to
25e3d07
Compare
Add a wrapper similar to `Hexf` to print integers with proper padding.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Make `Float::NAN` a qNaN, add sNaNs, and add operations to check whether a NaN is quiet or signaling.
Give more descriptive output in tests since we sometimes need to treat these differently. We still don't parse `sNaN`/`qNaN` for now, though we could in the future.
We do handle signaling NaNs properly, with the exception of raising exceptions as IEEE 754 requires. Add tests to this effect for `fmin`, `fminimum`, `fminimum_num`, and the max variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do handle signaling NaNs properly, with the exception of raising
exceptions as IEEE 754 requires. Add tests to this effect for
fmin,fminimum,fminimum_num, and the max variants.ci: allow-many-extensive
ci: allow-regressions (hex float printing)