Merged
Conversation
trybuild didn't like being run as an msp43-none-elf target, so we have to run the test with --target x86 to overrule the .cargo/config rule, then in the test harness set environment flags back to targetting the msp430, so when trybuild compiles the examples they're successfully built as msp430 binaries.
cr1901
requested changes
Jul 25, 2025
Contributor
Author
|
Ah right, I had done all my testing on a self-hosted runner. I've set it as |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken CI, and accepts minor changes to error outputs that have occurred while the CI has been broken.
The
macroworkspace inherited themsp430-none-elftarget from.cargo/config.toml, which caused some issues. To get around this we override that by invoking the test suite with--target=x86_64-unknown-linux-gnuso the trybuild runner gets built on the host architecture. Then, to ensure the tests themselves compile as msp430 binaries we have to fiddle with environment variables in the test runner so the tests are correctly built targetting the msp430 (andbuild-stdis correctly passed through).