Implement GetRawMempoolSequence return type for getrawmempool RPC
#478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types/src/model/blockchain.rs
Outdated
| /// List of transaction ids in the mempool. | ||
| pub txids: Vec<Txid>, | ||
| /// The mempool sequence value. | ||
| pub mempool_sequence: bitcoin::Sequence, |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub mempool_sequence: bitcoin::Sequence, | |
| pub mempool_sequence: u64, |
bitcoin::Sequence is a transaction input sequence.
types/src/v21/blockchain/mod.rs
Outdated
| /// List of transaction ids in the mempool. | ||
| pub txids: Vec<String>, | ||
| /// The mempool sequence value. | ||
| pub mempool_sequence: u32, |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub mempool_sequence: u32, | |
| pub mempool_sequence: u64, |
I think a mempool sequence is u64 in Core?
Contributor
Author
There was a problem hiding this comment.
Confirmed it is u64 and made the change.
natobritto
force-pushed
the
fix-getrawmempool
branch
3 times, most recently
from
3e8a0b4 to
4928178
Compare
tcharding
reviewed
Jan 27, 2026
types/src/v21/blockchain/into.rs
Outdated
Comment on lines
212
to
216
| // Parse txid strings into `bitcoin::Txid`. | ||
| let txids = | ||
| self.txids.iter().map(|t: &String| t.parse::<Txid>()).collect::<Result<Vec<_>, _>>()?; | ||
|
|
||
| Ok(model::GetRawMempoolSequence { txids, mempool_sequence: self.mempool_sequence }) |
Member
There was a problem hiding this comment.
Can be more simply written as
let txids = self.txids.iter().map(|t| t.parse::<Txid>()).collect::<Result<Vec<_>, _>>()?;
Ok(model::GetRawMempoolSequence { txids, mempool_sequence: self.mempool_sequence })
tcharding
reviewed
Jan 27, 2026
Comment on lines
20
to
22
| } | ||
| pub fn get_raw_mempool_verbose(&self) -> Result<GetRawMempoolVerbose> { |
Member
There was a problem hiding this comment.
nit: A line of whitespace between the functions here please mate.
When getrawmempool is called with verbose set to false and mempool_sequence set to true, a distinct type is returned. This commit implements that return type with test, from version v21 through v30.
natobritto
force-pushed
the
fix-getrawmempool
branch
from
4928178 to
7706c36
Compare
tcharding
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
getrawmempoolRPC is called with optional verbose argument set tofalseand subsequentmempool_sequenceset totrue, a distinct type is returned from v21 onward to v30. This PR implements this return type with corresponding tests.Partially fixes issue #474.