Open
Conversation
Adjust library code to make dynamic behavior explicit for the type checker with small, behavior-preserving changes: add local narrowing, nil guards, key coercions, read_body call shaping, and a few compatibility-focused internal fixes.
Update the public RBS to better match actual net/http behavior around URI handling, nilable headers and response bodies, exception classes, and request/response entry points. Keep shipped signatures in sig/ focused on net/http’s public API, and add a separate *-impl.rbs files for implementation-only declarations used only by Steep when typechecking lib/. The *-impl.rbs files cover internal protocol classes, helper methods, constants, and stdlib gaps needed by the implementation, without shipping those internal details as part of the gem’s public RBS.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #278 for context.