Skip to content

Add Symbol arguments to .mode, #round in BigDecimal #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Feb 13, 2026
Merged

Add Symbol arguments to .mode, #round in BigDecimal #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gems/bigdecimal/3.1/_test/test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
12r.to_d(3)
0i.to_d

BigDecimal("1.234").round(2)
BigDecimal("1.234").round(2, BigDecimal::ROUND_UP)
BigDecimal("1.234").round(2, :up)

require "bigdecimal/math"

BigMath.E(10)
Expand Down
4 changes: 2 additions & 2 deletions gems/bigdecimal/3.1/bigdecimal.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ class BigDecimal < Numeric
# `:ceil`.
# * `ROUND_FLOOR`: Round toward negative infinity. Aliased as `:floor:`.
#
def self.mode: (Integer mode, ?Integer? value) -> Integer?
def self.mode: (Integer mode, ?(Integer | Symbol | nil) value) -> Integer?

# <!--
# rdoc-file=ext/bigdecimal/bigdecimal.c
Expand Down Expand Up @@ -854,7 +854,7 @@ class BigDecimal < Numeric
# is performed; see BigDecimal.mode.
#
def round: () -> Integer
| (Numeric n, ?Integer mode) -> BigDecimal
| (Numeric n, ?(Integer | Symbol) mode) -> BigDecimal

# <!--
# rdoc-file=ext/bigdecimal/bigdecimal.c
Expand Down
4 changes: 4 additions & 0 deletions gems/bigdecimal/4.0/_test/test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
12r.to_d(3)
0i.to_d

BigDecimal("1.234").round(2)
BigDecimal("1.234").round(2, BigDecimal::ROUND_UP)
BigDecimal("1.234").round(2, :up)

require "bigdecimal/math"

BigMath.E(10)
Expand Down
4 changes: 2 additions & 2 deletions gems/bigdecimal/4.0/bigdecimal.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ class BigDecimal < Numeric
# `:ceil`.
# * `ROUND_FLOOR`: Round toward negative infinity. Aliased as `:floor:`.
#
def self.mode: (Integer mode, ?Integer? value) -> Integer?
def self.mode: (Integer mode, ?(Integer | Symbol | nil) value) -> Integer?

# <!--
# rdoc-file=ext/bigdecimal/bigdecimal.c
Expand Down Expand Up @@ -839,7 +839,7 @@ class BigDecimal < Numeric
# is performed; see BigDecimal.mode.
#
def round: () -> Integer
| (Numeric n, ?Integer mode) -> BigDecimal
| (Numeric n, ?(Integer | Symbol) mode) -> BigDecimal

# <!--
# rdoc-file=ext/bigdecimal/bigdecimal.c
Expand Down