fix(cli): propagate child exit code from piano profile#211
Merged
rocketman-code merged 1 commit intomainfrom Mar 1, 2026
Merged
fix(cli): propagate child exit code from piano profile#211rocketman-code merged 1 commit intomainfrom
rocketman-code merged 1 commit intomainfrom
Conversation
When the profiled program exits non-zero, piano profile now exits with the same code instead of always returning 0. The --ignore-exit-code flag suppresses both the warning and the exit code propagation. Also fixes NoRuns suppression when --ignore-exit-code is set: a failed program that produces no profiling data no longer triggers NoDataWritten. Closes #93
rocketman-code
force-pushed
the
fix/propagate-exit-code
branch
from
e3a7593 to
06903a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
piano profilenow exits with the profiled program's exit code when it exits non-zero (previously always exited 0)--ignore-exit-codesuppresses both the warning and exit code propagationNoRunssuppression when--ignore-exit-codeis set: a failed program that produces no data no longer triggersNoDataWrittenTest plan
profile_propagates_child_exit_code— verifies Piano exits code 1 when child exits 1profile_ignore_exit_code_returns_success— verifies Piano exits 0 with--ignore-exit-codeCloses #93