fix(report): use RunNotFound for missing tags#199
Merged
rocketman-code merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
When resolve_tag() encounters a file-not-found error, map it to RunNotFound instead of RunReadError to avoid leaking internal file paths and to show a user-friendly message. Closes #198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_tag()toRunNotFoundinstead ofRunReadErrorBefore:
error: failed to read run file /path/to/target/piano/tags/nonexistent: No such file or directoryAfter:
error: no run found for tag 'nonexistent' -- run piano tag to see available tagsTest plan
resolve_tag_errors_on_missing_tagto assertRunNotFoundvariantCloses #198