fix(cli): fix cargo subcommand invocation and flag parsing#5
Merged
rocketman-code merged 1 commit intomainfrom Feb 23, 2026
Merged
fix(cli): fix cargo subcommand invocation and flag parsing#5rocketman-code merged 1 commit intomainfrom
rocketman-code merged 1 commit intomainfrom
Conversation
Fix subcommand stripping that was dead code (checked argv[0] == "cargo" but cargo sets argv[0] to binary path). Use CARGO env var to detect cargo subcommand invocation, only stripping argv[1] == "avail" when invoked via cargo. Remove allow_hyphen_values which caused flags after positional args to be swallowed as crate names.
rocketman-code
force-pushed
the
fix/cargo-subcommand-parsing
branch
from
ee26ec1 to
e41cea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo availinvocation being completely broken — subcommand stripping never fired because it checked argv[0] == "cargo" but cargo invokes the binary as "cargo-avail"allow_hyphen_valueswhich caused all flags (--json,--version,--quiet,--available-only) to be swallowed as crate names when any positional arg preceded themTest plan
cargo test --workspace— 38 passed, 0 failedcargo clippy --workspace --all-targets -- -D warnings— cleancargo avail --version,cargo avail --help,cargo avail serde,cargo avail std --json,cargo avail --quiet serde, stdin piping, canonical dedup,--separator for hyphen names