Skip to content

fix: resolve 6 high-severity bugs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robotlearning123 merged 2 commits into from
Jan 23, 2026
Merged

fix: resolve 6 high-severity bugs #33

robotlearning123 merged 2 commits into from
Jan 23, 2026

Conversation

@robotlearning123
Copy link
Owner

@robotlearning123 robotlearning123 commented Jan 23, 2026

Summary

Fixes 6 high-severity bugs identified during code review:

  • Silent hook failures - Hook errors now tracked in metadata; critical hooks (priority < 10) stop execution on failure
  • RPC memory leak - Added createdAt timestamp and cleanupStaleRequests() to prevent unbounded pendingRequests growth
  • Silent JSON parse errors - Now logs parse errors with content preview for debugging
  • Silent skill command errors - Captures full error details including stderr and exit codes
  • Background task memory leak - Auto-cleanup of tasks older than 1 hour, capped at 100 tasks
  • Unsafe command execution - Added security documentation for skill command execution

Test plan

  • TypeScript compilation passes
  • ESLint passes
  • All 116 tests pass
  • Manual verification of error logging in hooks
  • Manual verification of RPC cleanup under load

🤖 Generated with Claude Code

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Jan 23, 2026

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026 •
edited
Loading

Warning

Rate limit exceeded

@robotlearning123 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

robotlearning123 and others added 2 commits January 22, 2026 20:46
@robotlearning123 @claude
test: add extended tool tests for bash, todo, undo, diff, and git
75e4662 
Add comprehensive test coverage for additional tools:
- Bash tool: command execution, stderr, exit codes, timeout, dangerous command warnings
- Todo tools: add, update, remove, clear, read, filter by status
- Undo tool: backup creation, restoration, listing
- Diff tool: file comparison, content comparison, identical detection
- Git tools: status, diff, commit with auto-generated and custom messages

Increases test count from 83 to 116 tests.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@robotlearning123 @claude
fix: resolve 6 high-severity bugs
7a2bb65 
- hooks/executor.ts: Track hook errors in metadata, stop execution for
  critical hooks (priority < 10) on failure instead of silently continuing

- rpc/client.ts: Log JSON parse errors with content preview instead of
  silently ignoring; add cleanupStaleRequests() to prevent memory leaks
  from unbounded pendingRequests map

- rpc/types.ts: Add createdAt timestamp to PendingRequest for cleanup

- skills/parser.ts: Capture full error details (stderr, exit code) for
  command failures; add security documentation for command execution

- background.ts: Add automatic cleanup of completed tasks (>1hr old),
  cap total tasks at 100 to prevent unbounded memory growth

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@robotlearning123 robotlearning123 merged commit dfb56b1 into main Jan 23, 2026
6 of 7 checks passed
@robotlearning123 robotlearning123 deleted the fix/high-severity-bugs branch January 23, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robotlearning123