You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
using cg_constrain would do no harm, but it would be good if the old functions were deprecated instead of directly renaming it... considering that there could be some projects using the framework without a version lock, it could cause lots of crashes, so IMO we could use something like:
on the old functions to point out that it will not be supported in the near future and users should migrate to this naming convention.
So later on those functions could be safely removed.
I've put some thought on it, and I think we should not rename constrain to cg_constrain, since we have Swift's modularity to play on our side;
Using Cartography.constrain just like a namespace would be a benefit in some ways since we'll always know where that constrain function came from.
IMO we could just leave it as is, and just push the docs update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a doc update with the usage hints, based on the problems found in Xcode 11 and as stated in this Pull Request #314