Use lightspeed_rag_content package in OpenShift docs processing#40
Merged
jpodivin merged 5 commits intoroad-core:mainfrom Mar 27, 2025
Merged
Conversation
a9e2ff4 to
0645673
Compare
umago
reviewed
Mar 24, 2025
This commit refactors the code responsible for cloning and converting of
AsciiDoc formatted OpenShift docs to text formatted files.
1. It moves all the AsciiDoc code related to OpenShift to examples
folder to ensure clear separation between OpenShift specific code
and road-core/rag-content code.
2. It makes sure the code specific to OpenShift uses
ligthspeed_rag_content.asciidoc package.
3. Removes all the ruby based asciidoctor extensions as they are
now part of lightspeed_rag_content package.
Signed-off-by: Lukas Piwowarski <lpiwowar@redhat.com>
asciidoctor is now installed by default in the base image. There is no need to install it again in the child image.
0645673 to
92032ed
Compare
Contributor
Author
Proof of testingI tested the change locally using the following command: Main branchlpiwowar:lpiwowar/refactor-openshift-asciidoc branch |
Contributor
Author
jpodivin
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the code responsible for cloning and converting of AsciiDoc formatted OpenShift docs to text formatted files.
It moves all the AsciiDoc code related to OpenShift to examples folder to ensure clear separation between OpenShift specific code and road-core/rag-content code.
It makes sure the code specific to OpenShift uses ligthspeed_rag_content.asciidoc package.
Removes all the ruby based
asciidoctorextensions as they are now part of lightspeed_rag_content package.Depends-On: #39