Make EKF more Generic and add TOML file for Handling Dependencies#301
Open
chacalnoir wants to merge 3 commits intorlabbe:masterfrom
Open
Make EKF more Generic and add TOML file for Handling Dependencies#301chacalnoir wants to merge 3 commits intorlabbe:masterfrom
chacalnoir wants to merge 3 commits intorlabbe:masterfrom
Conversation
chacalnoir
commented
Jan 29, 2024
- The original EKF assumes a linear, time invariant (LTI) transition matrix. That is, in general, not a requirement for an EKF. Since the measurement Jacobian can be overridden, the transition matrix should also be able to be computed at each step. This PR adds an override to enable that capability.
- The original install method was via setup.py only. This doesn't work with newer build systems that are using TOML files, as the dependencies don't seem to be handled correctly. This PR updates the setup.py file to be a TOML file instead to correctly handle dependencies.
- The README docs mentioned that Python 2.7 and 3.4 support was supposed to be dropped around 2018. The setup.py file doesn't show this. As part of updating to the TOML file, the classifiers were also updated to be Python 3.7.
- As part of the TOML file, I did add in flake8 and autopep definitions. They are not being used to lint currently, but provide the basis for linting if desired.
|
@rlabbe Any interest in merging this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.