fix: use custom modulemap to prevent Xcode 26 ODR errors with CocoaPods#428
Open
mfazekas wants to merge 1 commit intorive-app:mainfrom
Open
fix: use custom modulemap to prevent Xcode 26 ODR errors with CocoaPods#428mfazekas wants to merge 1 commit intorive-app:mainfrom
mfazekas wants to merge 1 commit intorive-app:mainfrom
Conversation
The auto-generated modulemap includes a .Swift Clang submodule referencing RiveRuntime-Swift.h, which bakes in Swift stdlib C++ interop definitions for the exact Swift version used to build. When CocoaPods consumers use a different Xcode/Swift version, the differing type definitions cause hard ODR errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The auto-generated modulemap includes a
module RiveRuntime.SwiftClang submodule that referencesRiveRuntime-Swift.h. This header bakes in Swift stdlib C++ interop type definitions for the exact Swift version used to build the XCFramework. When CocoaPods consumers use a different Xcode/Swift version (e.g. Swift 6.2 in Xcode 26 vs Swift 6.1), the differing definitions cause hard ODR errors that cannot be suppressed. SPM is unaffected since it uses.swiftinterfacefiles directly.This PR adds a custom modulemap without the
.Swiftsubmodule and setsMODULEMAP_FILEin the base xcconfig so Xcode uses it during builds. The-Swift.hheader still ships in the framework for direct#importuse.See rive-app/rive-nitro-react-native#174