style: enhance swift api usage and eliminate force casts#424
Closed
MojtabaHs wants to merge 4 commits intorive-app:mainfrom
Closed
style: enhance swift api usage and eliminate force casts#424MojtabaHs wants to merge 4 commits intorive-app:mainfrom
MojtabaHs wants to merge 4 commits intorive-app:mainfrom
Conversation
MojtabaHs
force-pushed
the
enhanve-code
branch
2 times, most recently
from
d867c49 to
4b1e3db
Compare
MojtabaHs
force-pushed
the
enhanve-code
branch
from
4b1e3db to
446d400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge combinations of
if ... is <Type>/... as! <Type>and convert them toif let ... as? <Type>to reduce the code smell and make the code fundamentally safer.Note: I've kept the formatting as it was to reduce the changes in the code and make it easier for the reviewer.