fix: add @objc to touch methods in ViewModel examples#408
Open
yoyoyoyolol wants to merge 1 commit intorive-app:mainfrom
Open
fix: add @objc to touch methods in ViewModel examples#408yoyoyoyolol wants to merge 1 commit intorive-app:mainfrom
yoyoyoyolol wants to merge 1 commit intorive-app:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The touch methods in the ViewModel example classes (
RiveSliderandRiveButton) were not being called because they lacked the@objcattribute.Details
Since
RiveStateMachineDelegateis an@objcprotocol with optional methods, the runtime usesrespondsToSelector:to check for implementation. In Swift, these methods must be explicitly marked with@objc(even if the class inherits fromNSObject) to be visible to the Objective-C runtime for dynamic dispatch in this context.Without this change, the slider and button in the "ViewModel Examples" section of the example app are non-functional.
Affected Files
Example-iOS/Source/Examples/ViewModel/RiveButton.swift